add pulser for connection + adjust condition for connnection_modal#2676
Merged
add pulser for connection + adjust condition for connnection_modal#2676
Conversation
Attach the pulse keyframes and imports to the icon itself so that the code gets properly included in stateful_components.js when it is used.
masenf
requested changes
Feb 24, 2024
masenf
previously approved these changes
Feb 24, 2024
masenf
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small
wifi_officon that pulse on bottom left when connection is down.connection_pulser is included in the
default_overlay_componentapparition of connection_banner is delayed a little, appear after a few failed attemps.