Skip to content

initial attempt at writing test for urls#2689

Merged
masenf merged 10 commits intomainfrom
test-for-incorrect-url-paths
Feb 29, 2024
Merged

initial attempt at writing test for urls#2689
masenf merged 10 commits intomainfrom
test-for-incorrect-url-paths

Conversation

@tgberkeley
Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@tgberkeley tgberkeley requested a review from masenf February 22, 2024 00:22
@tgberkeley tgberkeley requested a review from Alek99 February 22, 2024 02:27
Comment thread integration/test_urls.py Outdated
Comment thread integration/test_urls.py Outdated
masenf
masenf previously approved these changes Feb 29, 2024
@masenf masenf merged commit 93fc269 into main Feb 29, 2024
@masenf masenf deleted the test-for-incorrect-url-paths branch February 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants