add more type annotations through the code #4401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Nov 22, 2024
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
Superficially looks fine, but I don't want to bring it in for 0.6.6; lets cut the release branch then we can bring this into main and get some runtime on it.
Contributor
Author
Sounds good, no hurry to merge this one 👍 |
adhami3310
reviewed
Jan 22, 2025
adhami3310
previously approved these changes
Jan 24, 2025
adhami3310
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes based on rules
ANN001fromruff