fix subprotocol for granian #4698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Jan 27, 2025
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
still doesn't work for uvicorn in dev mode accessing on chrome
|
FYI, the ASGI protocol specifies you should just use the |
Member
Author
Thanks for the link, we were struggling with this a bit. The issue is that Granian/Uviocorn/Gunicorn behave slightly differently in different systems. We couldn't figure out why and how to reproduce it reliably so we opted out for using the header if it's there and subprotocol if it's there. |
masenf
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.