Skip to content

reflex core is typed#6271

Merged
adhami3310 merged 1 commit intomainfrom
reflex-core-is-typed
Apr 1, 2026
Merged

reflex core is typed#6271
adhami3310 merged 1 commit intomainfrom
reflex-core-is-typed

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@adhami3310 adhami3310 merged commit 980a97d into main Apr 1, 2026
39 checks passed
@adhami3310 adhami3310 deleted the reflex-core-is-typed branch April 1, 2026 17:43
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing reflex-core-is-typed (f089e5d) with main (57119bc)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (1e91dea) during the generation of this report, so 57119bc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 1, 2026

Greptile Summary

This PR adds a py.typed marker file to the reflex_core package, declaring PEP 561 compliance. This is the standard, minimal way to signal to type checkers (mypy, pyright, etc.) that the package ships inline type annotations and that they should be used during static analysis.

  • Adds an empty packages/reflex-core/src/reflex_core/py.typed marker file (the correct format per PEP 561 — presence of the file is the signal, content is irrelevant).
  • The pyproject.toml uses hatchling with a src layout; hatchling will automatically include all package-tracked files (including py.typed) in built wheels, so no pyproject.toml changes are needed.
  • No functional or behavioral changes; this is purely a packaging/metadata improvement.

Confidence Score: 5/5

  • Safe to merge — adds a standard, empty PEP 561 marker file with no functional changes.
  • The change is a single empty file following a well-established Python packaging standard (PEP 561). There are no logic changes, no new dependencies, and the build system (hatchling with src layout) will include it automatically. No issues were found.
  • No files require special attention.

Important Files Changed

Filename Overview
packages/reflex-core/src/reflex_core/py.typed Adds an empty PEP 561 marker file to declare that reflex_core ships inline type annotations, enabling type checkers to use them.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Type Checker\ne.g. mypy / pyright] -->|imports reflex_core| B{py.typed present?}
    B -->|No - before this PR| C[Treat package as untyped\nignore annotations]
    B -->|Yes - after this PR| D[Read inline type annotations\nfrom package source]
    D --> E[Provide accurate type errors\nand completions for users]
Loading

Reviews (1): Last reviewed commit: "reflex core is typed" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants