-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(app): pass Reflex app instance to lifespan task app parameter #6358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BABTUNA
wants to merge
1
commit into
reflex-dev:main
Choose a base branch
from
BABTUNA:fix-6331-lifespan-app-instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| """Unit tests for lifespan mixin behavior.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
|
|
||
| import pytest | ||
| from starlette.applications import Starlette | ||
|
|
||
| from reflex.app_mixins.lifespan import LifespanMixin | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_lifespan_task_app_param_receives_reflex_app_instance(): | ||
| """Lifespan tasks should receive the Reflex app instance, not Starlette.""" | ||
|
|
||
| class DummyApp(LifespanMixin): | ||
| """Minimal test app based on the lifespan mixin.""" | ||
|
|
||
| app = DummyApp() | ||
| received: dict[str, object] = {} | ||
|
|
||
| def lifespan_task(app): | ||
| """Record the app argument injected by the lifespan runner. | ||
|
|
||
| Args: | ||
| app: App object injected by the lifespan runner. | ||
| """ | ||
| received["app"] = app | ||
|
|
||
| app.register_lifespan_task(lifespan_task) | ||
|
|
||
| async with app._run_lifespan_tasks(Starlette()): | ||
| await asyncio.sleep(0) | ||
|
|
||
| assert received["app"] is app | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
starlette_appinjectionThe PR introduces
starlette_appas a new injectable parameter for lifespan tasks, but the test suite only verifies theapp(Reflex instance) injection path. A complementary test coveringstarlette_appinjection — and ideally a task that declares both parameters simultaneously — would complete coverage for the new feature.