fix: drop temporal=True from fetch_recent_blogs#6399
Conversation
The Resources navbar dropdown's `blog_column` mounts during initial render (via Radix navigation menu's pre-mounted panels). Its `on_mount=RecentBlogsState.fetch_recent_blogs` races the WebSocket handshake; with `temporal=True` the event is silently dropped if the socket isn't yet connected, and `on_mount` doesn't refire — so the column stays empty on slow connects. Without `temporal`, the event queues and fires once the socket is up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR removes Confidence Score: 5/5Safe to merge — single-parameter removal that correctly resolves a documented race condition with no side-effects on the existing guard logic. The change is a one-line removal of No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant RadixMenu as Radix Nav Menu
participant WS as WebSocket
participant Backend as RecentBlogsState
Browser->>RadixMenu: Initial render
RadixMenu->>Browser: Pre-mount blog_column panel (on_mount fires)
Note over Browser,WS: WS handshake still in progress on slow connects
alt temporal=True (old behavior)
Browser->>WS: Enqueue fetch_recent_blogs
WS-->>Browser: Event DROPPED (socket not yet connected)
Note over Browser: Blog column stays empty — on_mount never refires
else temporal=False (new behavior)
Browser->>WS: Enqueue fetch_recent_blogs
WS->>WS: Queue event until socket is ready
WS->>Backend: Deliver fetch_recent_blogs
Backend->>Backend: HTTP GET /recent-blogs (background task)
Backend-->>Browser: State update: posts = [...]
Browser->>Browser: Blog column renders cards
end
Reviews (1): Last reviewed commit: "fix: drop temporal=True from fetch_recen..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing |
No description provided.