Skip to content

Fix doc popover transparent background and contrast#6407

Merged
carlosabadia merged 1 commit intomainfrom
carlos/fix-popover-bg-transparent
Apr 28, 2026
Merged

Fix doc popover transparent background and contrast#6407
carlosabadia merged 1 commit intomainfrom
carlos/fix-popover-bg-transparent

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners April 28, 2026 09:32
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR fixes the doc popover's transparent background and low-contrast text by replacing hardcoded slate-*/violet-* Tailwind tokens with semantic secondary-*/primary-* tokens throughout the docpage template. It also restructures the copy-page popover to delegate background, border, shadow, and rounding to the ui.popover.popup component (via class_name="p-0 overflow-hidden") instead of manually applying those styles on an inner div.

Confidence Score: 4/5

Safe to merge; all findings are visual/P2 and the color token migration is consistent.

No logic or security issues. Three P2 style observations (missing separator margins, removed entrance animation, unspecified popover side offset) that could cause minor visual regressions but do not affect functionality.

docs/app/reflex_docs/templates/docpage/docpage.py — specifically the popover positioner and separator div changes around lines 527–549.

Important Files Changed

Filename Overview
docs/app/reflex_docs/templates/docpage/docpage.py Replaces hardcoded slate/violet color tokens with semantic secondary/primary tokens throughout the docpage, and restructures the copy-page popover to rely on the popup component's built-in styling rather than manual class_name overrides; three minor visual regressions (missing separator margins, removed entrance animation, unspecified popover side).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Copy page button (left half)"] -->|on_click| B["copy_action()"]
    C["Dropdown trigger (right half)"] -->|click| D["ui.popover.root"]
    D --> E["ui.popover.portal"]
    E --> F["ui.popover.positioner\nalign=end, align_offset=-4"]
    F --> G["ui.popover.popup\nclass: p-0 overflow-hidden"]
    G --> H["rx.el.div\nclass: flex flex-col min-w-260px"]
    H --> I["_build_reflex_menu_item\nprimary-* gradient colors"]
    H --> J["_copy_page_menu_item\nCopy page as Markdown"]
    H --> K["Separator div\nbg-secondary-4"]
    H --> L["_copy_page_menu_item\nOpen in ChatGPT"]
    H --> M["_copy_page_menu_item\nOpen in Claude"]
Loading

Reviews (1): Last reviewed commit: "Fix doc popover transparent background a..." | Re-trigger Greptile

Comment thread docs/app/reflex_docs/templates/docpage/docpage.py
Comment thread docs/app/reflex_docs/templates/docpage/docpage.py
Comment thread docs/app/reflex_docs/templates/docpage/docpage.py
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing carlos/fix-popover-bg-transparent (007665d) with main (3fdcaf4)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (eb43df4) during the generation of this report, so 3fdcaf4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@carlosabadia carlosabadia merged commit 68fabcf into main Apr 28, 2026
68 of 69 checks passed
@carlosabadia carlosabadia deleted the carlos/fix-popover-bg-transparent branch April 28, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants