fix rx-shout integration test for new uv project structure#6470
Conversation
Greptile SummaryThis PR updates the
Confidence Score: 4/5The workflow logic is sound but a stray tab character on line 190 of the YAML file could prevent the workflow from parsing correctly under a strict YAML parser. The approach of patching pyproject.toml and using uv sync is correct for the new project structure, and the os.kill change in wait_for_listening_port.py is a clean POSIX improvement. The one concern is the tab-indented comment on line 190 of integration_tests.yml — it is invalid per the YAML spec, and if GitHub's parser ever tightens up or a pre-commit lint step runs, the entire workflow file would be rejected. .github/workflows/integration_tests.yml — line 190 has a tab character where spaces are required by the YAML spec. Important Files Changed
Reviews (2): Last reviewed commit: "remove long comment" | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
avoid case of mixed installation from local/pypi for reflex subpackages
os.kill(pid, 0) is the stdlib equivalent everywhere except Windows, where psutil is already a transitive runtime dep of reflex. Drops the manual uv pip install psutil from the rx-shout job, which was landing in the wrong venv anyway because setup-uv activates the repo-root venv. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
because we're installing reflex in an editable way, it will use the local specification's from reflex's pyproject.toml when it installs.
|
@greptile |
No description provided.