Skip to content

Update shared components for new web design#6474

Open
carlosabadia wants to merge 7 commits intomainfrom
carlos/update-shared-components
Open

Update shared components for new web design#6474
carlosabadia wants to merge 7 commits intomainfrom
carlos/update-shared-components

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners May 8, 2026 12:18
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing carlos/update-shared-components (366ef77) with main (1eed933)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Greptile Summary

This PR migrates shared marketing components (navbar, footer, CTA card, hosting banner) to a new web design, replacing m-slate-* design tokens with semantic secondary-*/primary-* tokens and restructuring layouts.

  • New workflow_stage.py introduces animated arrow-sweep visuals (CSS mask-image + phased translateX animation) used in the Products mega-menu to represent the Build/Iterate/Ship workflow.
  • Navbar redesign replaces the "Platform/Resources/About" structure with "Products/Resources/Solutions/Enterprise" mega-menus, and removes the logos_carousel in favour of per-column imagery.
  • Footer redesign restructures the two-column layout into a left sidebar (logo, newsletter, socials, dark-mode toggle) plus a five-column link grid and adds new "Migration" and "Company" link sections.

Confidence Score: 5/5

Safe to merge — changes are additive visual redesigns with no mutation of data, state, or routing logic.

All changes are confined to UI component trees, CSS design tokens, and SVG icon additions. The new workflow_stage.py animation logic is well-contained and the CSS backwards fill-mode correctly handles staggered delays. Imports (demo_form_dialog, all constant URLs, new icons) are verified to exist. No business logic, API calls, or data-layer code is touched.

No files require special attention; the diverging style in the local docpage.py copy of menu_socials is cosmetic and was already surfaced in a prior review thread.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/views/workflow_stage.py New file: builds animated arrow-row visuals using a CSS mask-image data-URL and a staggered translateX sweep animation. Logic for percent-encoding, delay calculation, and mask rendering is sound.
packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py Major structural refactor: replaced Platform/About menus with Products/Resources/Solutions mega-menus; demo_form_dialog correctly imported from reflex_components_internal.blocks.demo_form.
packages/reflex-site-shared/src/reflex_site_shared/views/footer.py Full footer layout redesign with new link columns and design token migration; social_menu_item updated to remove ghost-button wrapper and use semantic color tokens directly.
docs/app/reflex_docs/templates/docpage/docpage.py Added a local copy of social_menu_item/menu_socials (removing the import from footer.py); local copy retains old ghost-button styling that diverges from the redesigned footer — noted in a prior review thread.
docs/app/assets/tailwind-theme.css Adds --arrow-sweep-duration, --animate-arrow-sweep CSS variables, --landing-layout-max-width, and the @Keyframes arrow-sweep definition; body migrated from bg-slate-1 to bg-secondary-1.
packages/reflex-site-shared/src/reflex_site_shared/components/icons.py Adds nine new SVG icons (grok, claude, openai, gemini, cursor, arrow_turn, reflex_small, docs, curved_line) and registers them in the ICONS dict.

Reviews (2): Last reviewed commit: "inline that" | Re-trigger Greptile

Comment thread docs/app/reflex_docs/templates/docpage/docpage.py
Comment thread docs/app/assets/tailwind-theme.css
Comment thread packages/reflex-site-shared/src/reflex_site_shared/views/workflow_stage.py Outdated
@masenf
Copy link
Copy Markdown
Collaborator

masenf commented May 8, 2026

@greptile-apps re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants