Remove redundant lost-and-found warning log#6527
Conversation
The warning "Failed to send delta to lost and found for client" was duplicative — emit_lost_and_found already logs the underlying cause (either "Redis token owner not found" or "Redis error publishing lost and found delta") for both failure modes. The extra warning wasn't actionable and confused users.
Greptile SummaryThis PR removes a redundant
Confidence Score: 5/5Safe to merge — the removed warning was purely cosmetic and every failure case remains logged inside the callee. The change is a four-line deletion of a warning that duplicated existing log output. All failure modes in emit_lost_and_found and _get_token_owner continue to log their own messages, so observability is unchanged. There is only one call site, no test regressions to worry about, and no behavioral change. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant EU as emit_update (app.py)
participant ELF as emit_lost_and_found (token_manager.py)
participant GTO as _get_token_owner
participant Redis
EU->>ELF: await emit_lost_and_found(token, update)
ELF->>GTO: _get_token_owner(token)
alt Token found in Redis
GTO-->>ELF: instance_id
ELF->>Redis: publish(lost_and_found_channel, record)
alt Publish succeeds
Redis-->>ELF: OK
ELF-->>EU: True (ignored)
else Publish fails
Redis-->>ELF: Exception
ELF->>ELF: console.error("Redis error publishing lost and found delta")
ELF-->>EU: False (ignored)
end
else Token NOT found in Redis
GTO->>GTO: console.warn("Redis token owner not found")
GTO-->>ELF: None
ELF-->>EU: False (ignored)
else Redis error getting token
GTO->>GTO: console.error("Redis error getting token owner")
GTO-->>ELF: None
ELF-->>EU: False (ignored)
end
Note over EU,ELF: Removed: console.warn("Failed to send delta to lost and found")
Reviews (1): Last reviewed commit: "Remove redundant lost-and-found warning ..." | Re-trigger Greptile |
This warning fired whenever a token wasn't registered in Redis, which can happen normally (e.g. expired tokens). It wasn't actionable and confused users.
The warning "Failed to send delta to lost and found for client" was duplicative — emit_lost_and_found already logs the underlying cause (either "Redis token owner not found" or "Redis error publishing lost and found delta") for both failure modes. The extra warning wasn't actionable and confused users.