Skip to content

Fix mobile drawer internal links in marketing navbar#6539

Merged
carlosabadia merged 2 commits into
mainfrom
carlos/fix-mobile-links
May 20, 2026
Merged

Fix mobile drawer internal links in marketing navbar#6539
carlosabadia merged 2 commits into
mainfrom
carlos/fix-mobile-links

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested a review from a team as a code owner May 20, 2026 10:06
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR fixes four incorrect internal links in the mobile navbar drawer by updating stale route paths to match current site routing conventions.

  • Templates: /gallery/templates
  • Components: /library/docs/library
  • Open Source: /framework/open-source
  • Cloud: /cloud/hosting

Confidence Score: 4/5

Safe to merge — the four URL corrections are straightforward and only touch the mobile drawer link targets.

The core URL fixes are correct and well-scoped. The only loose end is that the docs active-detection exclusion list still references "gallery" instead of "templates" now that the Templates route moved; this doesn't produce wrong active-state today (since /templates never contains "docs"), but it is dead code that should be cleaned up.

The active-detection exclusion in drawer_item (lines 66–73) is the one spot worth a second look.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/views/sidebar/init.py Corrects four stale URLs in the mobile navbar drawer (Templates: /gallery→/templates, Components: /library→/docs/library, Open Source: /framework→/open-source, Cloud: /cloud→/hosting); the "gallery" exclusion in the docs active-detection logic was not updated to match the new "templates" path.

Comments Outside Diff (1)

  1. packages/reflex-site-shared/src/reflex_site_shared/views/sidebar/__init__.py, line 66-73 (link)

    P2 The "gallery" exclusion inside the drawer_item active-detection logic for "Docs" is now stale. The Templates link was updated from /gallery to /templates, but the exclusion list on line 70 still checks router_path.contains("gallery"). Functionally this is harmless today (since /templates does not contain "docs"), but it leaves dead code that no longer serves its original purpose and could confuse future maintainers.

Reviews (1): Last reviewed commit: "Fix mobile drawer links" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing carlos/fix-mobile-links (15fe85e) with main (fc7221a)

Open in CodSpeed

@carlosabadia carlosabadia requested a review from Alek99 as a code owner May 20, 2026 10:10
@carlosabadia carlosabadia merged commit 2aa49c5 into main May 20, 2026
70 checks passed
@carlosabadia carlosabadia deleted the carlos/fix-mobile-links branch May 20, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants