Skip to content

Fix feedback popover bg color#6540

Merged
adhami3310 merged 2 commits into
mainfrom
carlos/fix-docs-feedback-bg
May 20, 2026
Merged

Fix feedback popover bg color#6540
adhami3310 merged 2 commits into
mainfrom
carlos/fix-docs-feedback-bg

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners May 20, 2026 10:25
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR fixes the feedback popover background color on doc pages by removing the render_= keyword argument from the ui.popover.popup() call in feedback_button(), so the content is now passed as a direct child (matching how the adjacent _copy_page_button popover already works). The change is accompanied by a routine batch of dependency upgrades across the docs app.

  • Core fix (docpage.py): ui.popover.popup(render_=feedback_content())ui.popover.popup(feedback_content()) — a one-liner that aligns with the existing _copy_page_button pattern on line 614.
  • New dependency (package.json): tailwindcss-scroll-mask is added with the version string \"0.0.3@2.0.0\", which is not a valid semver specifier and may cause install failures.
  • Dependency bumps (package.json, bun.lock): Upgrades to react/react-dom 19.2.6, react-router 7.15.0, tailwindcss 4.3.0, vite 8.0.12, rolldown 1.0.0 (stable), and several other transitive packages.

Confidence Score: 4/5

The Python fix is a clean, minimal change that is safe to merge. The non-standard tailwindcss-scroll-mask version string warrants verification before the docs app is rebuilt.

The popover change is correct and low-risk. The "0.0.3@2.0.0" version specifier for tailwindcss-scroll-mask is malformed and could break the docs app build or silently install the wrong package version.

docs/app/reflex.lock/package.json — the tailwindcss-scroll-mask version string needs to be verified or corrected.

Important Files Changed

Filename Overview
docs/app/reflex_docs/templates/docpage/docpage.py Removes render_= keyword argument from ui.popover.popup() in feedback_button(), passing feedback_content() as a positional child — the targeted bg-color fix. Logic is consistent with the sibling _copy_page_button usage on line 614.
docs/app/reflex.lock/package.json Routine version bumps (react-router 7.15.0, tailwindcss 4.3.0, react 19.2.6, vite 8.0.12, etc.) plus a new tailwindcss-scroll-mask dependency with the non-standard version string "0.0.3@2.0.0".
docs/app/reflex.lock/bun.lock Lock file updated to reflect all package version bumps in package.json; includes resolved hashes for all new versions including the new tailwindcss-scroll-mask entry.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[feedback_button] --> B[ui.popover.root]
    B --> C[ui.popover.trigger]
    B --> D[ui.popover.portal]
    D --> E[ui.popover.positioner]
    E -->|Before: render_=feedback_content| F_old["ui.popover.popup(render_=feedback_content())\n❌ bg color not applied"]
    E -->|After: positional child| F_new["ui.popover.popup(feedback_content())\n✅ bg color applied correctly"]
    F_new --> G[feedback_content]
    G --> H[rx.form with textarea, thumbs, email, submit]
Loading

Reviews (1): Last reviewed commit: "Fix feedback popover bg color" | Re-trigger Greptile

Comment thread docs/app/reflex.lock/package.json Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing carlos/fix-docs-feedback-bg (ad085b0) with main (fc7221a)

Open in CodSpeed

@adhami3310 adhami3310 merged commit a0afa89 into main May 20, 2026
70 checks passed
@adhami3310 adhami3310 deleted the carlos/fix-docs-feedback-bg branch May 20, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants