Skip to content

README.md: link to static video asset for PyPI, etc#6584

Merged
masenf merged 1 commit into
mainfrom
masenf/readme-video-link
May 29, 2026
Merged

README.md: link to static video asset for PyPI, etc#6584
masenf merged 1 commit into
mainfrom
masenf/readme-video-link

Conversation

@masenf
Copy link
Copy Markdown
Collaborator

@masenf masenf commented May 29, 2026

Updated video link in README for image generation app.

  1. embedded video must be hosted as a github attachment to be rendered inline on github
  2. <video> does not render on PyPI so it falls back to the link+img
  3. embedded video link is not accessible directly, so also host the video on R2 bucket so link works

Updated video link in README for image generation app.
@masenf masenf requested review from a team and Alek99 as code owners May 29, 2026 16:18
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR updates the fallback link for the image-generation demo video in README.md. The <video> element keeps its GitHub attachment as the playback source (works on GitHub), while the inner <a> fallback href is changed to a directly accessible R2-hosted URL so it works on PyPI and other renderers that don't support inline <video>.

  • The src on the <video> tag is unchanged; only the <a href> inside the fallback content is updated to https://web.reflex-assets.dev/video/reflex-dalle-video-2x.mp4.
  • No code or logic is affected; this is a documentation-only change.

Confidence Score: 5/5

Safe to merge — a single-line documentation change with no effect on code or runtime behavior.

The change is confined to the fallback anchor inside a <video> tag in README.md. It swaps one URL for another that is publicly hosted on the project's own R2 bucket, matching the stated intent. No logic, tests, or generated artifacts are touched.

No files require special attention.

Important Files Changed

Filename Overview
README.md Single-line change replacing the fallback anchor href inside a <video> tag from a non-directly-accessible GitHub attachment URL to a publicly hosted R2 bucket URL

Reviews (1): Last reviewed commit: "README.md: link to static video asset fo..." | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing masenf/readme-video-link (d87661b) with main (3b70322)

Open in CodSpeed

@masenf masenf merged commit 7281317 into main May 29, 2026
29 checks passed
@masenf masenf deleted the masenf/readme-video-link branch May 29, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants