Fix total_pages for empty or incompletely-loaded table to 1#50
Merged
picklelo merged 1 commit intoreflex-dev:mainfrom Dec 13, 2024
Merged
Fix total_pages for empty or incompletely-loaded table to 1#50picklelo merged 1 commit intoreflex-dev:mainfrom
picklelo merged 1 commit intoreflex-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the
table_statebackend component in an app that loads the table from an API call.While the table is loading, the UI would display
Page 1 of 0, becausepage_numberis always at-least 1, wheretotal_pageshad anelsecondition setting it to 0.This fixes that.