Merge pull request #2401 from teojgo/bugfix/find_modules_duplicates

[bugfix] Fix `find_modules` to return unique module names

Author: Vasileios Karakasis

reframe/utility/__init__.py

@@ -678,7 +678,7 @@ def _is_valid_for_env(m, e):
     for p in current_system.partitions:
         for e in p.environs:
             rt.loadenv(p.local_env, e)
-            modules = ms.available_modules(substr)
+            modules = OrderedSet(ms.available_modules(substr))
             snap0.restore()
             for m in modules:
                 if _is_valid_for_env(m, e.name):

unittests/test_utility.py

@@ -1450,16 +1450,24 @@ def user_exec_ctx(request, make_exec_ctx_g):
 
 
 @pytest.fixture
-def modules_system(user_exec_ctx, monkeypatch):
+def modules_system(user_exec_ctx, monkeypatch, tmp_path):
     # Pretend to be on a clean modules environment
     monkeypatch.setenv('MODULEPATH', '')
     monkeypatch.setenv('LOADEDMODULES', '')
     monkeypatch.setenv('_LMFILES_', '')
 
+    # Create a symlink to testmod_foo to check for unique module names
+    # found by `find_modules`
+    (tmp_path / 'testmod_foo').symlink_to(
+        os.path.join(test_util.TEST_MODULES, 'testmod_foo')
+    )
+
     ms = rt.runtime().system.modules_system
+    ms.searchpath_add(str(tmp_path))
     ms.searchpath_add(test_util.TEST_MODULES)
     yield ms
     ms.searchpath_remove(test_util.TEST_MODULES)
+    ms.searchpath_remove(str(tmp_path))
 
 
 def test_find_modules(modules_system):