[bugfix] Fix find_modules to return unique module names
#2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2022-01-31 08:45:30 UTC |
Contributor
Author
|
@akesandgren can you check if this solves your problem? |
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 56 56
Lines 10465 10465
=======================================
Hits 8962 8962
Misses 1503 1503
Continue to review full report at Codecov.
|
vkarak
requested changes
Jan 28, 2022
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Just a very minor comment.
vkarak
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2296