Single-char scheduler options passed through `-J` are not handled properly

[rsarm]

Here opt is the complete option (something like A=usup), not just the flag. The length is not 1, then it never goes to the elif len(opt) == 1 resulting in adding two minuses (--A) when it should be a single one (-A):

        for opt in options.job_options:
            if opt.startswith('-') or opt.startswith('#'):
                parsed_job_options.append(opt)
            elif len(opt) == 1:
                parsed_job_options.append(f'-{opt}')
            else:
                parsed_job_options.append(f'--{opt}')

[rsarm]

I think here we can have options that are flag foo=bar, flag=foo=bar, flag='foo bar' and flag 'foo bar'. That can make the parser for knowing when to add - or -- a bit complicated. I think reframe should take and pass the options verbatim to the job script: -J='#BATCH --flag foo' or -J='--flag foo' and drop the support for adding - or --. What do think @vkarak?

[vkarak]

@rsarm Can you pass -A=usup to Slurm or does it have to be -A usup or --account=usup. I think the -A=usup is not POSIX compliant.

[vkarak]

I think what is problematic there is the len(opt) == 1. We should split opt on = or a space and then check. Something like this:

        for opt in options.job_options:
            optstr = re.split(r'=|\s+', opt, maxsplit=1)
            if opt.startswith('-') or opt.startswith('#'):
                parsed_job_options.append(opt)
            elif len(optstr) == 1:
                parsed_job_options.append(f'-{opt}')
            else:
                parsed_job_options.append(f'--{opt}')