Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 5, 2019

This introduces a an API for a Node, which the Job talks to for determining
whether the node is available or not. Different backends implement that
differently.

Also made private the SlurmNode class and the create_nodes() function.

Fixes #1087.

This introduces a an API for a Node, which the Job talks to for determining
whether the node is available or not. Different backends implement that
differently.

Also made private the `SlurmNode` class and the `create_nodes()` function.
@vkarak vkarak added this to the ReFrame sprint 2019w48 milestone Dec 5, 2019
@vkarak vkarak requested review from teojgo and victorusu December 5, 2019 18:21
@vkarak vkarak self-assigned this Dec 5, 2019
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1088 into master will decrease coverage by <.01%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1088      +/-   ##
=========================================
- Coverage   91.71%   91.7%   -0.01%     
=========================================
  Files          81      81              
  Lines       11110   11121      +11     
=========================================
+ Hits        10190   10199       +9     
- Misses        920     922       +2
Impacted Files Coverage Δ
unittests/test_schedulers.py 96.76% <100%> (+0.02%) ⬆️
reframe/core/schedulers/local.py 100% <100%> (ø) ⬆️
reframe/core/schedulers/__init__.py 95.68% <100%> (+0.06%) ⬆️
reframe/core/schedulers/slurm.py 55% <50%> (ø) ⬆️
reframe/core/config.py 82.9% <0%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a5917...781ed61. Read the comment docs.

@vkarak vkarak merged commit 63eb9c5 into reframe-hpc:master Dec 6, 2019
@vkarak vkarak deleted the bugfix/local-sched-flex-alloc branch December 6, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flexible node allocation fails with local scheduler

3 participants