Skip to content

[test] Add check for Slurm error message when no constraint is given #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 19, 2019
Merged

[test] Add check for Slurm error message when no constraint is given #1104

merged 6 commits into from
Dec 19, 2019

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Dec 16, 2019 •
edited by vkarak
Loading

The error in the sanity pattern may be too specific for daint and dom. It could also change to something more generic, like error: You have to specify, at least, what sort of node you need:.

Fixes UES-427

@ekouts ekouts added this to the ReFrame sprint 2019w50 milestone Dec 16, 2019
@ekouts ekouts requested review from teojgo and vkarak December 16, 2019 16:51
@ekouts ekouts self-assigned this Dec 16, 2019
@ekouts ekouts changed the title Add check for Slurm error message when no constraint is given [test] Add check for Slurm error message when no constraint is given Dec 16, 2019
vkarak
vkarak requested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test lgtm, but can you please update the syntax of the whole file, so that it uses the pipeline hooks?

vkarak
vkarak reviewed Dec 16, 2019
View reviewed changes
@pep8speaks
Copy link

pep8speaks commented Dec 18, 2019 •
edited
Loading

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-12-18 22:53:18 UTC

@ekouts
Copy link
Contributor Author

ekouts commented Dec 18, 2019 •
edited
Loading

@jenkins-cscs retry all

@vkarak
Copy link
Contributor

vkarak commented Dec 18, 2019

I am doing some fine tuning of the test and will push shortly.

Vasileios Karakasis added 2 commits December 18, 2019 16:08
Fine tune Slurm tests
d945043 
- Also make hostname pattern check more precise to avoid false matches with the
  output from job report
Merge branch 'master' into test/slurm-constraint-error
ee362e3
@vkarak
Copy link
Contributor

vkarak commented Dec 18, 2019

@jenkins-cscs retry daint

@vkarak vkarak merged commit 4d2ae5d into reframe-hpc:master Dec 19, 2019
@ekouts ekouts deleted the test/slurm-constraint-error branch January 16, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@ekouts ekouts

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w50

Development

Successfully merging this pull request may close these issues.

4 participants

@ekouts @pep8speaks @vkarak @teojgo