[bugfix] Fix incomplete printout of the performance report in case of test failures #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not print the performance report table if no performance report values are present. * Put printing of num_tasks in the correct if block.
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 81 81
Lines 11629 11629
=======================================
Hits 10686 10686
Misses 943 943Continue to review full report at Codecov.
|
vkarak
changed the title
vkarak
requested changes
Jan 17, 2020
Contributor
|
@teojgo All unit tests are failing. Can you fix it so that we can merge this one? |
vkarak
changed the title
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not print the performance report table if no performance report
values are present.
Put printing of num_tasks in the correct if block.
Fixes #1081