Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jan 17, 2020

  • Deprecate using the checkpath command line option multiple times
    and issue a warning.

  • Create unittest for colon separated paths.

  • Add the change to the documentation.

Fixes #1120.

* Deprecate using the checkpath command line option multiple times
  and issue a warning.

* Create unittest for colon separated paths.

* Add the change to the documentation.
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #1125 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage    91.9%   91.92%   +0.02%     
==========================================
  Files          81       81              
  Lines       11642    11642              
==========================================
+ Hits        10699    10702       +3     
+ Misses        943      940       -3
Impacted Files Coverage Δ
reframe/frontend/cli.py 80.87% <ø> (+0.31%) ⬆️
reframe/core/exceptions.py 84.78% <0%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9161612...eba14ab. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 20.01 milestone Jan 21, 2020
@vkarak vkarak changed the title [feat] Allow passing of colon separated checkpaths [feat] Do not allow chaining of the -c option; pass multiple paths as a colon separated list Jan 23, 2020
@vkarak
Copy link
Contributor

vkarak commented Jan 24, 2020

@ekouts Can you also approve this, so that we can merge it?

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 194db5d into reframe-hpc:master Jan 27, 2020
@teojgo teojgo deleted the feature/colon_separated_check_paths branch February 19, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make -c option accept colon separated paths instead of appending to the check search path

4 participants