Skip to content

Conversation

@ajocksch
Copy link
Contributor

@ajocksch ajocksch commented Jan 31, 2020

This PR considers the new compiler flags for the Cray compiler (clang).

The old flags still exist in PrgEnv-cray_classic.

@ajocksch ajocksch requested a review from vkarak January 31, 2020 13:10
@ajocksch ajocksch self-assigned this Jan 31, 2020
@vkarak vkarak changed the title WIP: trilinos Cray clang [wip] [test] trilinos Cray clang Feb 3, 2020
@vkarak
Copy link
Contributor

vkarak commented Feb 5, 2020

@ajocksch Please add a description to your PR.

@vkarak
Copy link
Contributor

vkarak commented Feb 18, 2020

@ajocksch Can you be more specific in your PR title and put a description of what this PR offers? Also why is it a WIP?

@ajocksch ajocksch changed the title [wip] [test] trilinos Cray clang [test] trilinos Cray clang Feb 21, 2020
@vkarak vkarak added this to the ReFrame sprint 20.03 milestone Feb 26, 2020
@vkarak vkarak changed the title [test] trilinos Cray clang [test] Adapt PrgEnv-cray flags for Trilinos check Feb 27, 2020
@vkarak
Copy link
Contributor

vkarak commented Feb 27, 2020

@jenkins-cscs retry dom

@vkarak
Copy link
Contributor

vkarak commented Feb 27, 2020

Test still fails on Dom. Please fix:

==============================================================================
SUMMARY OF FAILURES
------------------------------------------------------------------------------
FAILURE INFO for TrilinosTest_static
  * System partition: dom:gpu
  * Environment: PrgEnv-cray_classic
  * Stage directory: /users/karakasv/Devel/reframe/stage/dom/gpu/PrgEnv-cray_classic/TrilinosTest_static
  * Node list: <None>
  * Job type: batch job (id=None)
  * Maintainers: ['AJ', 'CB']
  * Failing phase: compile_wait
  * Reason: build error: standard error can be found in `rfm_TrilinosTest_static_build.err', standard output can be found in `rfm_TrilinosTest_static_build.out'
------------------------------------------------------------------------------
FAILURE INFO for TrilinosTest_static
  * System partition: dom:mc
  * Environment: PrgEnv-cray_classic
  * Stage directory: /users/karakasv/Devel/reframe/stage/dom/mc/PrgEnv-cray_classic/TrilinosTest_static
  * Node list: <None>
  * Job type: batch job (id=None)
  * Maintainers: ['AJ', 'CB']
  * Failing phase: compile_wait
  * Reason: build error: standard error can be found in `rfm_TrilinosTest_static_build.err', standard output can be found in `rfm_TrilinosTest_static_build.out'
------------------------------------------------------------------------------

@vkarak
Copy link
Contributor

vkarak commented Feb 27, 2020

Also there tons of warnings for the PrgEnv-cray.

@ajocksch
Copy link
Contributor Author

Cray case #257684 about trilinos not supported for cce/xxx-classic

@ajocksch
Copy link
Contributor Author

the warnings come from the trilinos header files, I see only the option to suppress them, changes to the c++ standard version did not help

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is 75.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          81       81           
  Lines       12028    12028           
=======================================
  Hits        11081    11081           
  Misses        947      947
Impacted Files Coverage Δ
reframe/core/exceptions.py 84.89% <100%> (ø) ⬆️
reframe/frontend/cli.py 81.05% <100%> (ø) ⬆️
unittests/test_policies.py 97.8% <69.56%> (ø) ⬆️
reframe/frontend/executors/__init__.py 97.66% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd5999...c501641. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Mar 3, 2020

@jenkins-cscs retry none

@vkarak vkarak merged commit edfda0b into reframe-hpc:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants