[feat] Support RFC3339 compliant time zone formatting when logging time fields #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 3, 2020 17:37
…irectives - Add unit tests for testing the formatting of `check_job_completion_time`. - Minor refactoring in logging unit tests
vkarak
commented
Feb 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 81 81
Lines 11693 11693
=======================================
Hits 10757 10757
Misses 936 936Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new time formatting directive for log record timestamps, namely the GNU
dateextension%:z. This directive will print the time zone difference in fully RFC3339 compliant way, i.e.,+/-HH:MMinstead or+/-HHMM, which%zprints.This PR also replaces how
Job's completion time is stored and retrieved, also inside the Slurm backend. We usetime.time()to retrieve the time in seconds from the Epoch instead ofdatetime.now(), becausedatetimedoes not store time zone information. Also all backends are now required to provide the completion time in seconds from the Epoch, so Slurm backend was modified accordingly.Fixes #1061.
@brandongc FYI