Skip to content

[test] Introduce workaround for static linking tests on Dom #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 6, 2020
Merged

[test] Introduce workaround for static linking tests on Dom #1151

merged 7 commits into from
Feb 6, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 4, 2020

  • Workaround for Cray Bug #255707.

Fix failing static linking tests on Dom
8fcdb41 
* Workaround for Cray Bug #255707.
@teojgo teojgo requested review from victorusu and vkarak February 4, 2020 13:49
@teojgo teojgo self-assigned this Feb 4, 2020
vkarak
vkarak requested changes Feb 4, 2020
View reviewed changes
@vkarak vkarak changed the title [bugfix] Fix failing static linking tests on Dom [test] Fix failing static linking tests on Dom Feb 4, 2020
@vkarak vkarak changed the title [test] Fix failing static linking tests on Dom [test] Introduce workaround for static linking tests on Dom Feb 4, 2020
@vkarak vkarak added this to the ReFrame sprint 20.01 milestone Feb 4, 2020
vkarak
vkarak requested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

victorusu
victorusu approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But I think the code can be a bit more generic if one uses the ALT_LINKER environment variable.

@vkarak
Copy link
Contributor

vkarak commented Feb 5, 2020

@teojgo It seems that this PR breaks the tests on Kesch. Can you check?

@vkarak
Copy link
Contributor

vkarak commented Feb 6, 2020

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #1151 into master will increase coverage by 0.02%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   91.96%   91.99%   +0.02%     
==========================================
  Files          81       81              
  Lines       11653    11693      +40     
==========================================
+ Hits        10717    10757      +40     
  Misses        936      936
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 54.54% <0%> (ø) ⬆️
unittests/test_logging.py 97.51% <100%> (+0.26%) ⬆️
reframe/core/logging.py 84.63% <100%> (+0.79%) ⬆️
reframe/core/schedulers/__init__.py 95.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b05b4...339d3d8. Read the comment docs.

@vkarak vkarak merged commit 13b56b4 into reframe-hpc:master Feb 6, 2020
@teojgo teojgo deleted the bugfix/dom_static_linkage branch February 19, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@teojgo teojgo

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.01

Development

Successfully merging this pull request may close these issues.

4 participants

@teojgo @vkarak @codecov-io @victorusu