[bugfix] Fix failure when check search path contains duplicates #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Duplicate check path is not added many times to the load path. * If the recursive option is passed, only the parent path of the checkpaths is used in the load path. * Create the corresponding unit tests.
vkarak
changed the title
victorusu
approved these changes
Feb 5, 2020
Contributor
victorusu
left a comment
victorusu
left a comment
There was a problem hiding this comment.
lgtm. I just have one question that is very minor.
Contributor
|
I have some comments on that one, I'll submit my review shortly. |
vkarak
requested changes
Feb 5, 2020
* Create utility function return the list of unique paths. * Address PR comments.
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 81 81
Lines 11736 11736
=======================================
Hits 10800 10800
Misses 936 936Continue to review full report at Codecov.
|
vkarak
requested changes
Feb 12, 2020
vkarak
requested changes
Feb 18, 2020
vkarak
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate check path is not added many times to the load path.
If the recursive option is passed, only the parent path of the
checkpaths is used in the load path.
Create the corresponding unit tests.
Fixes #1119