-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Port ReFrame checks on Arolla and Tsa with PE 19.04 #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removing blank line
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now. Thanks @lucamar for the effort!
|
@lucamar The PR seems to be breaking CDO tests on Kesch: https://jenkins.cscs.ch/blue/organizations/jenkins/ReframeCI/detail/ReframeCI/2966/pipeline/20, whereas they don't fail on master. |
|
@vkarak Thanks for the information, my last commit should have fixed the issue with CDO on Kesch. |
|
Thanks @lucamar. If the CI passes except for the failures mentioned in the description, I will merge this PR. |
|
@lucamar Some more tests are broken on Kesch. Tsa/Arolla seem fine. Can you please check? |
Fix CDO merge and info tests
|
I was not able to reproduce the failure of |
|
@jenkins-cscs retry tsa |
|
The other failure on Kesch is Therefore I have increased the expected value to the average of the above 8 results (i.e. |
|
I can confirm that now only the checks expected to fail are not yet passing on Tsa (see list above). |
|
@jenkins-cscs retry kesch |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of minor comments. I could fix them.
|
For DGEMM and GPU burn on Kesch we should open internal issues. |
|
@jenkins-cscs retry kesch tsa |
|
Thanks @lucamar for this PR. I will now merge it. Check UES-717 and UES-718 for the failures on Kesch. |
The pull request defines the checks that are currently run on the MCH system Kesch on the new systems Arolla and Tsa. Only few checks still need to be adapted (
Fieldextra,LETKF,...).Expected failures in this pull request that are still under investigation (checked if fixed):