Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Feb 14, 2020

Fixes UES-676

@rsarm rsarm added this to the ReFrame sprint 20.02 milestone Feb 14, 2020
@rsarm rsarm requested review from teojgo and vkarak February 14, 2020 15:18
@rsarm rsarm self-assigned this Feb 14, 2020
@vkarak
Copy link
Contributor

vkarak commented Feb 17, 2020

@rsarm Does it simply address UES-676 or does it fix it? If it only addresses it, why does it not fix it?

@vkarak
Copy link
Contributor

vkarak commented Feb 19, 2020

@rsarm Can you please also update the PR title accordingly?

@rsarm rsarm changed the title [feat] Add option to choose pulling or not an image before running with Sarus [feat] Add support for locally-loaded images with Sarus Feb 20, 2020
@rsarm rsarm changed the title [feat] Add support for locally-loaded images with Sarus [feat] Add support for images loaded locally with Sarus Feb 20, 2020
@pep8speaks
Copy link

pep8speaks commented Feb 20, 2020

Hello @rsarm, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-02-20 23:21:15 UTC

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #1170 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          81       81           
  Lines       11755    11755           
=======================================
  Hits        10819    10819           
  Misses        936      936
Impacted Files Coverage Δ
unittests/test_shell.py 100% <ø> (ø) ⬆️
unittests/test_buildsystems.py 99.16% <ø> (ø) ⬆️
reframe/core/runtime.py 89.69% <ø> (ø) ⬆️
unittests/resources/checks/frontend_checks.py 99.21% <ø> (ø) ⬆️
reframe/core/launchers/registry.py 85% <ø> (ø) ⬆️
unittests/resources/checks/bad/noentry.py 80% <ø> (ø) ⬆️
reframe/core/fields.py 98.94% <ø> (ø) ⬆️
reframe/frontend/dependency.py 96.77% <ø> (ø) ⬆️
unittests/resources/settings.py 100% <ø> (ø) ⬆️
reframe/core/meta.py 100% <ø> (ø) ⬆️
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f13978...ff39fcf. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @rsarm!

@vkarak vkarak changed the title [feat] Add support for images loaded locally with Sarus [feat] Allow Sarus backend to load local images Feb 21, 2020
@vkarak vkarak merged commit f9b15ed into reframe-hpc:master Feb 21, 2020
@rsarm rsarm deleted the feat/sarus-pull branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants