Skip to content

[feat] Set default value of sourcesdir to 'src' only if such a directory exists, otherwise set to None #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2020
Merged

[feat] Set default value of sourcesdir to 'src' only if such a directory exists, otherwise set to None #1185

merged 5 commits into from
Feb 25, 2020

Conversation

@victorusu
Copy link
Contributor

@victorusu victorusu commented Feb 19, 2020 •
edited by vkarak
Loading

If the test is derived from RunOnlyRegressionTest, then it does not have
to create a src/ dir in the test folder anymore. By default, if there is
no src/ dir, then ReFrame will set the self.sourcesdir to None.

Close #1094

@victorusu
[feat] Drop depenency on src dir for RunOnlyTests
ba5470c 
If the test is derived from RunOnlyRegressionTest, then it does not have
to create a `src` dir in the test folder anymore. By default if there is
no `src` dir, then ReFrame will set the `self.sourcesdir` to `None`.
@victorusu victorusu added this to the ReFrame sprint 20.02 milestone Feb 19, 2020
@victorusu victorusu requested review from teojgo and vkarak February 19, 2020 13:43
@victorusu victorusu self-assigned this Feb 19, 2020
teojgo
teojgo requested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unittests fail because the test._prefix is set after the initialization of the test in https://github.com/victorusu/reframe/blob/ba5470c41153495a2f343ac5dd3e3e6506e20c6a/unittests/test_pipeline.py#L195.

@vkarak vkarak changed the title [feat] Drop depenency on src dir for RunOnlyTests [feat] Do not require a sourcesdir by default for RunOnlyRegressionTest Feb 20, 2020
vkarak
vkarak previously requested changes Feb 20, 2020
View reviewed changes
@vkarak vkarak self-assigned this Feb 24, 2020
Vasileios Karakasis added 2 commits February 24, 2020 20:22
Merge branch 'master' into feature/no-src-dir-runonlytest
84b952b
Change default for sourcesdir conditionally for all types of tests
ac9081f 
If an `src/` directory is found inside the test's prefix, this will be used,
otherwise, `sourcesdir` will be set to `None`.
@pep8speaks
Copy link

pep8speaks commented Feb 25, 2020 •
edited
Loading

Hello @victorusu, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-02-25 13:51:25 UTC

@vkarak vkarak changed the title [feat] Do not require a sourcesdir by default for RunOnlyRegressionTest [feat] Set default value of sourcesdir to 'src' only if such a directory exists, otherwise set to None Feb 25, 2020
@vkarak vkarak dismissed their stale review February 25, 2020 10:57

I took over the implementation, so somebody else must review.

@vkarak
Copy link
Contributor

vkarak commented Feb 25, 2020

@teojgo Please review this one.

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ba5470c). Click here to learn what that means.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1185   +/-   ##
=========================================
  Coverage          ?   92.17%           
=========================================
  Files             ?       81           
  Lines             ?    12003           
  Branches          ?        0           
=========================================
  Hits              ?    11064           
  Misses            ?      939           
  Partials          ?        0
Impacted Files Coverage Δ
reframe/core/runtime.py 89.69% <ø> (ø)
unittests/resources/checks/frontend_checks.py 99.21% <ø> (ø)
reframe/core/launchers/registry.py 85% <ø> (ø)
unittests/resources/checks/bad/noentry.py 80% <ø> (ø)
reframe/utility/os_ext.py 91% <ø> (ø)
reframe/frontend/dependency.py 96.77% <ø> (ø)
unittests/resources/settings.py 100% <ø> (ø)
reframe/core/meta.py 100% <ø> (ø)
reframe/core/exceptions.py 84.78% <ø> (ø)
reframe/core/systems.py 89.67% <ø> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5470c...8cfa3e5. Read the comment docs.

teojgo
teojgo approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak
Copy link
Contributor

vkarak commented Feb 25, 2020

@jenkins-cscs retry daint

@vkarak vkarak merged commit 067a557 into reframe-hpc:master Feb 25, 2020
@victorusu victorusu deleted the feature/no-src-dir-runonlytest branch October 6, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak left review comments

@teojgo teojgo teojgo approved these changes

Assignees

@vkarak vkarak

@victorusu victorusu

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.02

Development

Successfully merging this pull request may close these issues.

test fail if 'src' directory is not present, even if no sources are required

5 participants

@victorusu @pep8speaks @vkarak @codecov-io @teojgo