Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 20, 2020

  • Use pytest syntax and pytest functions for skipping/failing.

  • Small fix in ScopedDict tests.

Fixes #1149

* Use pytest syntax and pytest functions for skipping/failing.

* Small fix in ScopedDict tests.
@teojgo teojgo added this to the ReFrame sprint 20.02 milestone Feb 20, 2020
@teojgo teojgo requested a review from ekouts February 20, 2020 13:45
@teojgo teojgo self-assigned this Feb 20, 2020
@vkarak vkarak changed the title [code quality] Convert unittests to pytest syntax [refactor] Convert unittests to pytest syntax Feb 20, 2020
@vkarak
Copy link
Contributor

vkarak commented Feb 20, 2020

@teojgo Why addresses and not fixes the issue?

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #1188 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1188      +/-   ##
=========================================
- Coverage   92.14%   91.9%   -0.25%     
=========================================
  Files          81      81              
  Lines       11930   11569     -361     
=========================================
- Hits        10993   10632     -361     
  Misses        937     937
Impacted Files Coverage Δ
reframe/core/containers.py 100% <100%> (ø) ⬆️
reframe/core/launchers/mpi.py 98.63% <100%> (+0.03%) ⬆️
reframe/core/schedulers/slurm.py 54.25% <100%> (-0.29%) ⬇️
reframe/core/fields.py 99% <100%> (+0.05%) ⬆️
unittests/test_launchers.py 92.72% <100%> (-1.48%) ⬇️
reframe/core/schedulers/pbs.py 68.29% <100%> (+0.79%) ⬆️
reframe/utility/__init__.py 90.12% <100%> (+0.06%) ⬆️
reframe/core/schedulers/local.py 100% <100%> (ø) ⬆️
unittests/test_fields.py 97.6% <100%> (+0.07%) ⬆️
reframe/core/pipeline.py 92.24% <100%> (-0.35%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030d1ed...8c3df25. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Feb 21, 2020

@teojgo Please also fix the conflicts with the current master.

@pep8speaks
Copy link

pep8speaks commented Feb 21, 2020

Hello @teojgo, Thank you for updating!

Line 29:80: E501 line too long (85 > 79 characters)

Line 20:39: E701 multiple statements on one line (colon)
Line 21:39: E701 multiple statements on one line (colon)
Line 22:39: E701 multiple statements on one line (colon)
Line 23:39: E701 multiple statements on one line (colon)
Line 24:39: E701 multiple statements on one line (colon)
Line 25:39: E701 multiple statements on one line (colon)
Line 49:39: E701 multiple statements on one line (colon)
Line 50:39: E701 multiple statements on one line (colon)
Line 51:39: E701 multiple statements on one line (colon)
Line 52:39: E701 multiple statements on one line (colon)
Line 53:39: E701 multiple statements on one line (colon)
Line 54:39: E701 multiple statements on one line (colon)
Line 55:39: E701 multiple statements on one line (colon)
Line 56:39: E701 multiple statements on one line (colon)

Do see the ReFrame Coding Style Guide

Comment last updated at 2020-02-21 13:37:25 UTC

@vkarak
Copy link
Contributor

vkarak commented Feb 21, 2020

@teojgo Apparently, PEP8 does not like the with Foo: do_sth() syntax. So let's revert back. Sorry for that.

@vkarak
Copy link
Contributor

vkarak commented Feb 21, 2020

@teojgo There are still some PEP8 issues. As soon as you fix them, we can merge this PR.

@teojgo
Copy link
Contributor Author

teojgo commented Feb 21, 2020

@teojgo There are still some PEP8 issues. As soon as you fix them, we can merge this PR.

@vkarak they are fixed but it seems pep8speaks has not taken the update into account

@vkarak vkarak merged commit 41ef4f0 into reframe-hpc:master Feb 21, 2020
@teojgo teojgo deleted the code_quality/convert2pytest branch March 4, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert all unit tests to pytest syntax

5 participants