[bugfix] Do not leave stale test jobs when ReFrame receives a TERM signal #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow ReFrame to exit with grace when it receives a SIGTERM. * Add unittest to simulate a SIGTERM handle.
added 2 commits
February 25, 2020 11:27
* Adjust unittests to simulate sending of a SIGTERM signal to ReFrame.
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 81 81
Lines 12028 12028
=======================================
Hits 11081 11081
Misses 947 947
Continue to review full report at Codecov.
|
vkarak
requested changes
Feb 25, 2020
vkarak
requested changes
Feb 25, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Almost there. I have just a couple of minor comments.
vkarak
changed the title
Contributor
|
@teojgo Strangely CI has finished successfully, but here it appears as still running. |
Contributor
|
@teojgo The test fails on Kesch. Moving over to the next sprint. |
Contributor
|
@jenkins-cscs retry kesch |
vkarak
requested changes
Feb 27, 2020
vkarak
requested changes
Feb 27, 2020
vkarak
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ReFrame to exit with grace when it receives a SIGTERM.
Add unittest to simulate a SIGTERM handle.
Fixes #1143