[test] Add GREASY test #1210
Merged
[test] Add GREASY test #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-04-09 13:03:28 UTC |
Contributor
|
@victorusu I'm scheduling this for the next sprint. |
victorusu
commented
Mar 3, 2020
vkarak
requested changes
Mar 17, 2020
vkarak
requested changes
Mar 27, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I have still some comments and there are still some previous comments that are not addressed yet.
vkarak
reviewed
Apr 7, 2020
vkarak
requested changes
Apr 7, 2020
Contributor
|
@victorusu The test failed in performance during the CI on Daint. Should we reconsider the reference? |
Contributor
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the GREASY test.
In order to run it properly on the GPU partition, as described in the documentation, one needs to add an additional constraint to the job script
This required me to change the
settings.pyfile