Skip to content

[bugfix] Fix random 'test_sigterm' unit test failure #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2020
Merged

[bugfix] Fix random 'test_sigterm' unit test failure #1217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions unittests/test_policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ def _runall(checks, conn):
except BaseException as e:
exc = e

conn.send((exc, len(self.runner.stats.failures())))
stats = self.runner.stats
conn.send((exc, stats.num_cases(), len(stats.failures())))
conn.close()

rd_endpoint, wr_endpoint = multiprocessing.Pipe(duplex=False)
Expand All @@ -286,8 +287,11 @@ def _runall(checks, conn):
time.sleep(1)
p.terminate()
p.join()
exc, num_failures = rd_endpoint.recv()
assert 1 == num_failures
exc, num_cases, num_failures = rd_endpoint.recv()

# Either the test is submitted and it fails due to the termination
# or it is not yet submitted when the termination signal is sent
assert (num_cases, num_failures) in {(1, 1), (0, 0)}
with pytest.raises(ReframeForceExitError,
match='received TERM signal'):
if exc:
Expand Down