Skip to content

Conversation

@victorusu
Copy link
Contributor

This PR changes the PrgEnv for all applications, that one is allowed to, to use the builtin PrgEnv. The intention is to avoid the creation of job scripts that are not used by users in production.

Before we used to have

#!/bin/bash                                                                        
#SBATCH --job-name="rfm_GromacsGPUCheck_small_prod_job"                            
...
#SBATCH --hint=nomultithread                                                       
module load daint-gpu                                                              
module unload PrgEnv-cray                                                          
module load PrgEnv-gnu  
module load GROMACS                                                                
export CRAY_CUDA_MPS=1                                                             
...

Now it should produce a more user realistic job script

#!/bin/bash                                                                        
#SBATCH --job-name="rfm_GromacsGPUCheck_small_prod_job"                            
...
#SBATCH --hint=nomultithread                                                       
module load daint-gpu                                                              
module load GROMACS                                                                
export CRAY_CUDA_MPS=1                                                             
...

@pep8speaks
Copy link

pep8speaks commented Mar 9, 2020

Hello @victorusu, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-03-12 22:22:48 UTC

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are much more to be changed. All tests that end up loading a toolchain from EB, they should use this approach. I made quick list of the missing ones. Make sure to update with master, because some of the tools tests have been removed from this repo.

cscs-checks/mch/fieldextra_check.py
cscs-checks/tools/io/cdo.py
cscs-checks/tools/io/nco.py
cscs-checks/libraries/hpx/hpx_hello_world.py
cscs-checks/libraries/magma/magma_checks.py
cscs-checks/libraries/hpx/hpx_stencil.py
cscs-checks/libraries/boost/boost_python_check.py
cscs-checks/libraries/io/netcdf_compile_run.py      # for the systems not using the Cray PE
cscs-checks/libraries/gridtools/gridtools_tests.py
cscs-checks/microbenchmarks/simd/vc.py
cscs-checks/microbenchmarks/simd/nsimd.py

EDIT: I removed the tools from the list, since most of them are used with multiple programming environments on purpose.

@vkarak vkarak changed the title [test] Use builtin PrgEnv for apps [test] Use builtin programming environment for tests loading EB modules Mar 11, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does not work on Kesch et al. So please revert the changes in the configuration and in the corresponding tests.

@vkarak
Copy link
Contributor

vkarak commented Mar 11, 2020

Also can you open internal issues for the tests in Daint/Dom that they don't work with the builtin environment?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@vkarak
Copy link
Contributor

vkarak commented Mar 12, 2020

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #1224 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1224   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          84       84           
  Lines       12209    12209           
=======================================
  Hits        11223    11223           
  Misses        986      986

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978a670...b8f1349. Read the comment docs.

@vkarak vkarak merged commit 1fdf880 into reframe-hpc:master Mar 12, 2020
@victorusu victorusu deleted the test/builtin-apps branch October 6, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants