-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Use builtin programming environment for tests loading EB modules #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-03-12 22:22:48 UTC |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are much more to be changed. All tests that end up loading a toolchain from EB, they should use this approach. I made quick list of the missing ones. Make sure to update with master, because some of the tools tests have been removed from this repo.
cscs-checks/mch/fieldextra_check.py
cscs-checks/tools/io/cdo.py
cscs-checks/tools/io/nco.py
cscs-checks/libraries/hpx/hpx_hello_world.py
cscs-checks/libraries/magma/magma_checks.py
cscs-checks/libraries/hpx/hpx_stencil.py
cscs-checks/libraries/boost/boost_python_check.py
cscs-checks/libraries/io/netcdf_compile_run.py # for the systems not using the Cray PE
cscs-checks/libraries/gridtools/gridtools_tests.py
cscs-checks/microbenchmarks/simd/vc.py
cscs-checks/microbenchmarks/simd/nsimd.py
EDIT: I removed the tools from the list, since most of them are used with multiple programming environments on purpose.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach does not work on Kesch et al. So please revert the changes in the configuration and in the corresponding tests.
|
Also can you open internal issues for the tests in Daint/Dom that they don't work with the |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 84 84
Lines 12209 12209
=======================================
Hits 11223 11223
Misses 986 986Continue to review full report at Codecov.
|
This PR changes the PrgEnv for all applications, that one is allowed to, to use the
builtinPrgEnv. The intention is to avoid the creation of job scripts that are not used by users in production.Before we used to have
Now it should produce a more user realistic job script