Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Mar 11, 2020

This feature is introduced to discourage users to override RegressionTest methods and use the hooks instead. If it is necessary, the user can still override the original methods but he has to use a new decorator that is also introduced in this pr.

Fixes #1130

Things to be done:

  • implement feature
  • unittests for the new feature
  • fixing the original unittests, so that they don't throw warnings
  • update documentation

@pep8speaks
Copy link

pep8speaks commented Mar 11, 2020

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-04-14 16:15:23 UTC

@vkarak vkarak changed the title [wip] Deprecate test syntax that overrides RegressionTest methods [wip] [feat] Deprecate test syntax that overrides RegressionTest methods Mar 11, 2020
@vkarak
Copy link
Contributor

vkarak commented Mar 11, 2020

Moving to next sprint; it's still a wip.

@ekouts ekouts changed the title [wip] [feat] Deprecate test syntax that overrides RegressionTest methods [feat] Deprecate test syntax that overrides RegressionTest methods Mar 18, 2020
@ekouts
Copy link
Contributor Author

ekouts commented Mar 24, 2020

@jenkins-cscs retry daint kesch

@vkarak
Copy link
Contributor

vkarak commented Apr 2, 2020

We will need to update the documentation as well.

@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #1228 into master will decrease coverage by 0.64%.
The diff coverage is 82.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   92.00%   91.35%   -0.65%     
==========================================
  Files          83       84       +1     
  Lines       12166    12495     +329     
==========================================
+ Hits        11193    11415     +222     
- Misses        973     1080     +107     
Impacted Files Coverage Δ
unittests/test_loader.py 83.67% <70.37%> (-16.33%) ⬇️
reframe/core/pipeline.py 92.70% <94.11%> (+0.33%) ⬆️
reframe/core/meta.py 100.00% <100.00%> (ø)
unittests/resources/checks/frontend_checks.py 99.22% <100.00%> (+<0.01%) ⬆️
...ittests/resources/checks_unlisted/kbd_interrupt.py 100.00% <100.00%> (ø)
reframe/core/config.py 51.23% <0.00%> (-33.26%) ⬇️
reframe/core/schedulers/torque.py 33.33% <0.00%> (-1.81%) ⬇️
unittests/test_schedulers.py 95.37% <0.00%> (-1.49%) ⬇️
reframe/core/schedulers/slurm.py 53.51% <0.00%> (-1.32%) ⬇️
reframe/core/schedulers/pbs.py 67.85% <0.00%> (-0.82%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d54313...2e6f821. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now. I will update the documentation and merge it.

@vkarak vkarak merged commit 8061111 into reframe-hpc:master Apr 14, 2020
@ekouts ekouts deleted the feat/deprecate-regtest-override branch April 16, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate test syntax that overrides RegressionTest methods

4 participants