-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Deprecate test syntax that overrides RegressionTest methods
#1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Deprecate test syntax that overrides RegressionTest methods
#1228
Conversation
|
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-04-14 16:15:23 UTC |
RegressionTest methodsRegressionTest methods
|
Moving to next sprint; it's still a wip. |
RegressionTest methodsRegressionTest methods
|
@jenkins-cscs retry daint kesch |
|
We will need to update the documentation as well. |
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
- Coverage 92.00% 91.35% -0.65%
==========================================
Files 83 84 +1
Lines 12166 12495 +329
==========================================
+ Hits 11193 11415 +222
- Misses 973 1080 +107
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now. I will update the documentation and merge it.
This feature is introduced to discourage users to override
RegressionTestmethods and use the hooks instead. If it is necessary, the user can still override the original methods but he has to use a new decorator that is also introduced in this pr.Fixes #1130
Things to be done: