-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Update tests for QuantumESPRESSO 6.5 #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-04-29 17:02:39 UTC |
|
@lucamar, the PR |
|
@victorusu The pseudopotentials used by QuantumESPRESSO are publicly available both on the QuantumESPRESSO web site and on the GitHub project space. The user should give credit to the author in a scientific publication, as well as for using the QuantumESPRESSO package itself: see https://www.quantum-espresso.org/pseudopotentials/about and our dedicated page on the User Portal https://user.cscs.ch/computing/applications/quantumespresso/#licensing-terms-and-conditions |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jenkins-cscs retry dom |
Co-Authored-By: Vasileios Karakasis <vkarak@gmail.com>
Co-Authored-By: Vasileios Karakasis <vkarak@gmail.com>
|
@jenkins-cscs retry dom |
|
@jenkins-cscs retry dom |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now. Thanks @lucamar !
|
@lucamar I've just noticed that one of the tests is still named the old way |
|
The problem is that the old file is not removed. I will fix that now and merge this. |
I propose an updated check for the release 6.5 of
QuantumESPRESSO, which now features a GPU enabled version forpw.x: I have created the tests based onsmallandlargechecks ofCP2K.Please note that the reference performance values are still tentative, as I have run few times only: I use the wall time reported in the program output, since the cpu time reports the sum over all threads.
I have changed the folder and filename from
espressotoquantumespresso, since all other checks of scientific applications are listed with the full name; furthermore,ESPRESSOis a different scientific package and using this name can create some confusion (see http://espressomd.org/wordpress).I have created the subfolder
srcwith the input file and the pseudopotential file, since they don't take much more space with respect to other checks (321K with respect to 241K ofCP2K) and it's better to track changes: therefore, I think that/apps/common/UES/regression/resources/Espressocould be be removed after the obsolete checkQECheck_smallthat still uses that path is removed as well.