[bugfix] Fix logging crash when increasing verbosity level #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorusu
changed the title
vkarak
changed the title
vkarak
requested changes
Apr 24, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
The fix is working however there are two things missing or need more thinking:
- We will need a unit test to reproduce the bug.
- The
check_job_completion_timeis not sent over to Graylog. Only the raw time is sent. I don't know if we can do something for that, because what is sent to Graylog are theextrasand not the formatted text. I don't know if formatting the message and sending it is the correct way to deal with that or formatting at the Graylog site is the best solution, but I kind of think the second one is at least more correct.
…/RFC3339Formatter
…/RFC3339Formatter
vkarak
requested changes
Apr 28, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Can you also add an entry in the documentation explaining the new field?
vkarak
approved these changes
Apr 28, 2020
vkarak
changed the title
added 2 commits
April 28, 2020 14:51
Contributor
|
@victorusu I've updated the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional field to the
LoggerAdapterclass as suggested by @vkarak. This new field holds the original UNIX time and it is used to format thecheck_job_completion_timefield.Fixes #1261
Fixes #1265