Skip to content

[test] Fix Slurm constraint check for cabinets #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2020
Merged

[test] Fix Slurm constraint check for cabinets #1296

merged 3 commits into from
May 8, 2020

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented May 7, 2020 •
edited
Loading

I also removed unnecessary programming environments from valid_prog_environs.

Fixes UES-859.

@vkarak vkarak added this to the ReFrame sprint 20.07 milestone May 7, 2020
@vkarak vkarak assigned victorusu, teojgo and vkarak and unassigned victorusu and teojgo May 7, 2020
@vkarak vkarak requested review from teojgo and victorusu May 7, 2020 11:55
teojgo
teojgo reviewed May 7, 2020
View reviewed changes
teojgo
teojgo reviewed May 7, 2020
View reviewed changes
teojgo
teojgo requested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to builtin prgenv

@vkarak
Copy link
Contributor Author

vkarak commented May 7, 2020

@teojgo I had the same thought, but I was reluctant to do it, because some tests do have a build step, so it's better not to rely on the builtin environment. But I have not a strong feeling about this. I could use builtin for the run-only tests and PrgEnv-cray for the rest.

@teojgo
Copy link
Contributor

teojgo commented May 7, 2020

@teojgo I had the same thought, but I was reluctant to do it, because some tests do have a build step, so it's better not to rely on the builtin environment. But I have not a strong feeling about this. I could use builtin for the run-only tests and PrgEnv-cray for the rest.

Ah ok, then it is fine for me.

@vkarak
Copy link
Contributor Author

vkarak commented May 7, 2020

CI is blocking due to #1298.

@vkarak vkarak merged commit 736670f into reframe-hpc:master May 8, 2020
@vkarak vkarak deleted the check/fix-slurm-constraint-check branch May 8, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teojgo teojgo teojgo approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@vkarak vkarak

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.07

Development

Successfully merging this pull request may close these issues.

3 participants

@vkarak @teojgo @victorusu