Skip to content

Conversation

@sekelle
Copy link
Contributor

@sekelle sekelle commented May 7, 2020

This adds a sanity check that the test has been assigned a number of processes that can be factorized as needed by the test.

Fixes UES-852.

@pep8speaks
Copy link

pep8speaks commented May 7, 2020

Hello @sebkelle1, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-05-08 07:40:30 UTC

@vkarak vkarak self-requested a review May 7, 2020 15:27
@vkarak vkarak added this to the ReFrame sprint 20.07 milestone May 7, 2020
@vkarak vkarak changed the title [bugfix] added invalid nrproc message [test] added invalid nrproc message May 7, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [test] added invalid nrproc message [test] Add specific failure message in HPCG test when number of processes cannot be factorized May 8, 2020
@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #1300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          83       83           
  Lines       12491    12491           
=======================================
  Hits        11447    11447           
  Misses       1044     1044           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ec271...5312034. Read the comment docs.

@vkarak vkarak merged commit 757dcb5 into reframe-hpc:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants