[bugfix] Use absolute path as stage and output directory prefixes #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2020 16:17
- This is specific to the filelog log handler and can be retrieved with the `--show-config` option.
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
- Coverage 91.68% 91.64% -0.04%
==========================================
Files 83 83
Lines 12490 12491 +1
==========================================
- Hits 11451 11447 -4
- Misses 1039 1044 +5
Continue to review full report at Codecov.
|
teojgo
approved these changes
May 8, 2020
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm, tested with the Greasy tests that makes use of the stage dir and now they work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove perflogdir from the output.
Fixes #1294.