Skip to content

Conversation

@lucamar
Copy link
Contributor

@lucamar lucamar commented May 12, 2020

The new check should address the request in CSCS RT #36652: in principle, the check could run on Kesch as well, however it makes use of recent ReFrame features not available in the module installed on the system ( reframe/2.19).
An update of the existing check using OpenAcc should be possible instead of creating a new check, although one would need to take into account the target systems without multiple GPU devices per node.

@pep8speaks
Copy link

pep8speaks commented May 12, 2020

Hello @lucamar, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-05-25 19:14:18 UTC

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, I have only a couple of minor comments.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kraushm kraushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

lucamar and others added 2 commits May 14, 2020 12:53
@lucamar
Copy link
Contributor Author

lucamar commented May 15, 2020

Do you know why ReFrame is failing today with the error below?

    import jsonschema
ModuleNotFoundError: No module named 'jsonschema'

@vkarak
Copy link
Contributor

vkarak commented May 15, 2020

@lucamar You should either load one of the latest reframe modules or install reframe's requirements pip install -r requirements.txt.

@lucamar
Copy link
Contributor Author

lucamar commented May 15, 2020

Thanks @vkarak, I have used pip install -r requirements.txt --user since I cannot write under the python folders installed by Jenkins and unfortunately on Tsa the only ReFrame module is reframe/2.18.

@lucamar lucamar changed the title [test] New check Set_Openacc_Device on Tsa [test] New check MultiDeviceOpenaccTest on Kesch and Tsa May 18, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only minor style comments. I can fix them myself.

@vkarak vkarak changed the title [test] New check MultiDeviceOpenaccTest on Kesch and Tsa [test] Add new MultiDeviceOpenaccTest on Kesch and Tsa May 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #1314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1314   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          83       83           
  Lines       12491    12491           
=======================================
  Hits        11459    11459           
  Misses       1032     1032           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d3ed8...8993d65. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 20.08 milestone May 25, 2020
@vkarak vkarak merged commit 372e168 into reframe-hpc:master May 25, 2020
@lucamar lucamar deleted the set_openacc_device branch May 26, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants