-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Add new MultiDeviceOpenaccTest on Kesch and Tsa #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-05-25 19:14:18 UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, I have only a couple of minor comments.
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kraushm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
|
Do you know why |
|
@lucamar You should either load one of the latest reframe modules or install reframe's requirements |
|
Thanks @vkarak, I have used |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only minor style comments. I can fix them myself.
Codecov Report
@@ Coverage Diff @@
## master #1314 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 83 83
Lines 12491 12491
=======================================
Hits 11459 11459
Misses 1032 1032 Continue to review full report at Codecov.
|
The new check should address the request in CSCS RT #36652: in principle, the check could run on Kesch as well, however it makes use of recent
ReFramefeatures not available in the module installed on the system (reframe/2.19).An update of the existing check using
OpenAccshould be possible instead of creating a new check, although one would need to take into account the target systems without multiple GPU devices per node.