Skip to content

[feat] Add JSON support to the configuration conversion tool #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2020
Merged

[feat] Add JSON support to the configuration conversion tool #1320

merged 3 commits into from
May 18, 2020

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 14, 2020

Closes #1282

@rsarm rsarm added this to the ReFrame sprint 20.07 milestone May 14, 2020
@rsarm rsarm requested review from ekouts and vkarak May 14, 2020 08:37
@rsarm rsarm self-assigned this May 14, 2020
@rsarm rsarm changed the title [feat] Add JSON support to the configuration conversion tool [wip][feat] Add JSON support to the configuration conversion tool May 14, 2020
@rsarm rsarm changed the title [wip][feat] Add JSON support to the configuration conversion tool [feat] Add JSON support to the configuration conversion tool May 14, 2020
@rsarm
Copy link
Contributor Author

rsarm commented May 14, 2020

@jenkins-cscs retry all

ekouts
ekouts approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of checking the extension of the new file to decide what it should be converted it to, instead of using some option and passing the right extension. Should we also include the -h option so that people know they can convert to different types of files?

vkarak
vkarak requested changes May 17, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ekouts that we should mention this capability in the conversion tool. I wouldn't add -h option, though. Just update the usage message. Also we should update the migration documentation. I can do this.

vkarak
vkarak approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak vkarak merged commit 8c1b070 into reframe-hpc:master May 18, 2020
@rsarm rsarm deleted the feat/convert-conf-json branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@rsarm rsarm

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.07

Development

Successfully merging this pull request may close these issues.

Add an option to emit JSON in the configuration conversion tool

3 participants

@rsarm @vkarak @ekouts