[bugfix] Fix handling of perflogdir in the configuration conversion tool
#1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
approved these changes
May 15, 2020
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm, tested with more than one testsys and it works fine
vkarak
requested changes
May 18, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
It's fine except that you should not generate a target_systems for the systems that they don't define the perflogdir (here generic and sys0).
|
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-05-18 14:38:30 UTC |
vkarak
approved these changes
May 18, 2020
vkarak
changed the title
perflogdir in the configuration conversion tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the conversion tool will create different handlers for every different
perflogdirin the old configuration file.Closes #1280.