Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 19, 2020

Fixes the build failure on readthedocs

# If your documentation needs a minimal Sphinx version, state it here.
#
needs_sphinx = '1.6.3'
needs_sphinx = '3.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, and I was always wondering why rtd was not using a more recent version of Sphinx :-)

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #1327 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage   91.73%   91.44%   -0.30%     
==========================================
  Files          83       83              
  Lines       12486    12058     -428     
==========================================
- Hits        11454    11026     -428     
  Misses       1032     1032              
Impacted Files Coverage Δ
...tests/resources/checks_unlisted/deprecated_test.py 53.84% <0.00%> (-3.30%) ⬇️
reframe/core/systems.py 86.06% <0.00%> (-2.13%) ⬇️
reframe/core/modules.py 60.51% <0.00%> (-1.93%) ⬇️
reframe/core/deferrable.py 92.94% <0.00%> (-1.79%) ⬇️
unittests/test_launchers.py 92.72% <0.00%> (-1.48%) ⬇️
unittests/test_environments.py 72.07% <0.00%> (-1.22%) ⬇️
reframe/core/exceptions.py 85.07% <0.00%> (-0.75%) ⬇️
reframe/core/schedulers/slurm.py 55.04% <0.00%> (-0.68%) ⬇️
reframe/core/environments.py 95.00% <0.00%> (-0.66%) ⬇️
unittests/test_containers.py 96.72% <0.00%> (-0.56%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7396547...85e8b5b. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 225cbc2 into reframe-hpc:master May 19, 2020
@teojgo teojgo deleted the docs/fix_sphinx_version branch May 25, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants