Skip to content

Conversation

@sleak-lbl
Copy link
Contributor

testing functionality of UPC and UPC++ code requires reframe to know how to compile and run UPC code. This PR adds those features

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #1333 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   91.77%   91.78%           
=======================================
  Files          83       83           
  Lines       12523    12561   +38     
=======================================
+ Hits        11493    11529   +36     
- Misses       1030     1032    +2     
Impacted Files Coverage Δ
reframe/core/buildsystems.py 96.75% <100.00%> (ø)
reframe/core/launchers/mpi.py 98.90% <100.00%> (+0.27%) ⬆️
unittests/test_launchers.py 94.93% <100.00%> (+0.73%) ⬆️
reframe/core/pipeline.py 92.84% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4781c...1c9849d. Read the comment docs.

@vkarak vkarak requested review from victorusu and vkarak May 22, 2020 08:17
@vkarak vkarak changed the title [feat] add support for UPC language and launchers [feat] Add support for UPC language and launchers May 23, 2020
@vkarak
Copy link
Contributor

vkarak commented May 25, 2020

@sleak-lbl We will also need an entry about these launchers in documentation here.

@vkarak
Copy link
Contributor

vkarak commented May 28, 2020

@sleak-lbl I think something got wrong with your updating this PR. It seems that you merged with your own modified master and pushed here. I'll try to fix it.

@vkarak vkarak force-pushed the feature/upc-support branch from 2763bc2 to ab3b23e Compare May 28, 2020 19:24
@vkarak
Copy link
Contributor

vkarak commented May 28, 2020

I forced push to this PR and fixed the commits. It seems that you have rebased locally over master and then you pushed here doing essentially a merge.

@vkarak
Copy link
Contributor

vkarak commented May 28, 2020

test this please

@vkarak vkarak added this to the ReFrame sprint 20.08 milestone May 28, 2020
@vkarak vkarak merged commit f13cb6a into reframe-hpc:master May 28, 2020
@sleak-lbl
Copy link
Contributor Author

oops, I was trying to rebase to the eth-cscs master, must have used the wrong one .. thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants