Skip to content

[bugfix] Fix configuration option value for non-existent name-addressable configuration objects #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2020
Merged

[bugfix] Fix configuration option value for non-existent name-addressable configuration objects #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec0d8c
Fix site_config.get() for non-existent name-addressable objects
May 26, 2020
8a5d99d
Merge branch 'master' into bugfix/default-config-value
May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion reframe/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ def get(self, option, default=None):
# Element addressable by name
x, found = x[1:], False
for obj in value:
value, found = obj, True
if obj['name'] == x:
value, found = obj, True
break
Expand Down
5 changes: 5 additions & 0 deletions unittests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,11 @@ def test_select_subconfig():
assert site_config.get('environments/0/cxx') == 'CC'
assert site_config.get('general/0/check_search_path') == ['c:d']

# Test default values for non-existent name-addressable objects
# See https://github.com/eth-cscs/reframe/issues/1339
assert site_config.get('modes/@foo/options') == []
assert site_config.get('modes/10/options') == []

# Test inexistent options
site_config.select_subconfig('testsys')
assert site_config.get('systems/1/name') is None
Expand Down