[bugfix] Fix the setup.py package installation script #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the `schemas` directory under `reframe`. * Make the necessary fixes to documentation. * Require `jsonschema` during installation of ReFrame. * Require Python>=3.6 for installation of ReFrame.
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
- Coverage 91.78% 91.71% -0.07%
==========================================
Files 83 83
Lines 12561 12572 +11
==========================================
+ Hits 11529 11531 +2
- Misses 1032 1041 +9
Continue to review full report at Codecov.
|
vkarak
requested changes
May 27, 2020
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-05-29 09:43:29 UTC |
vkarak
requested changes
May 28, 2020
vkarak
requested changes
May 29, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I just have two minor suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
schemasdirectory underreframe.Make the necessary fixes to documentation.
Require
jsonschemaduring installation of ReFrame.Require Python>=3.6 for installation of ReFrame.