Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented May 27, 2020

Fixes #1049.

FYI @bcfriesen you can now either export RFM_IGNORE_REQNODENOTAVAIL=yes or set the ignore_reqnodenotavail configuration parameter to True.

@bcfriesen
Copy link
Contributor

Great! Thanks @vkarak. I'll test this this week.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #1342 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1342   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          83       83           
  Lines       12595    12599    +4     
=======================================
+ Hits        11544    11548    +4     
  Misses       1051     1051           
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 56.11% <100.00%> (+0.39%) ⬆️
reframe/frontend/cli.py 77.64% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0360a7e...4126144. Read the comment docs.

@vkarak
Copy link
Contributor Author

vkarak commented Jun 2, 2020

@bcfriesen Did you have time to test this one? If not, since it'd require you to move to 3.0 right away essentially, I could merge it anyway and if you see problems we can fix them in a later PR.

@bcfriesen
Copy link
Contributor

Hi @vkarak, no I'm still migrating to the 3.0 series. Please feel free to merge this and I'll open an issue if it doesn't work as expected. Thanks!

@vkarak vkarak merged commit 4238dc4 into reframe-hpc:master Jun 2, 2020
@vkarak vkarak deleted the bugfix/reqnodenotavail branch June 2, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReqNodeNotAvail reason code causes ReFrame to incorrectly kill jobs on Cori at NERSC

4 participants