Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented May 28, 2020

Will fix UES-842

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #1344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1344   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          83       83           
  Lines       12599    12599           
=======================================
  Hits        11548    11548           
  Misses       1051     1051           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24eae1c...57cdb09. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm apart from a minor comment. You will need to fix the conflicts though that were just introduced :-)

@vkarak vkarak removed this from the ReFrame sprint 20.08 milestone Jun 2, 2020
@vkarak vkarak added this to the ReFrame sprint 20.08 milestone Jun 3, 2020
@vkarak vkarak changed the title [test] Converting JacobiNoToolHybrid to pipeline hook format [test] Convert JacobiNoToolHybrid to pipeline hook format Jun 3, 2020
@vkarak vkarak merged commit 55b9a94 into master Jun 3, 2020
@vkarak vkarak deleted the UES-842 branch June 3, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants