Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jun 2, 2020

Remove:

  • --flex-alloc-tasks option from cli
  • evaluate and make_deferrable in deferrable.py

The features and options that are not deprecated yet in reframe 3.0 are tracked in different issues.

Closes #1317.

 - Remove --flex-alloc-tasks option from cli
 - Remove evaluate and make_deferrable in deferrable.py
@ekouts ekouts added this to the ReFrame sprint 20.08 milestone Jun 2, 2020
@ekouts ekouts requested review from teojgo and vkarak June 2, 2020 20:55
@ekouts ekouts self-assigned this Jun 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #1357 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   91.65%   91.71%   +0.05%     
==========================================
  Files          83       83              
  Lines       12599    12586      -13     
==========================================
- Hits        11548    11543       -5     
+ Misses       1051     1043       -8     
Impacted Files Coverage Δ
reframe/core/deferrable.py 97.50% <ø> (+2.76%) ⬆️
reframe/frontend/cli.py 77.98% <ø> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b9a94...337c0af. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I only have a minor comment.

@vkarak vkarak changed the title [feat] Drop support of old deprecated features [feat] Drop option --flex-alloc-tasks and internal sanity function utilities Jun 3, 2020
@vkarak vkarak changed the title [feat] Drop option --flex-alloc-tasks and internal sanity function utilities [feat] Drop option --flex-alloc-tasks and internal unused sanity function utilities Jun 3, 2020
@vkarak vkarak merged commit 6f59055 into reframe-hpc:master Jun 3, 2020
@ekouts ekouts deleted the feat/drop_old_feats branch June 3, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit deprecated features and options and consider removing them completely for 3.0

3 participants